Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nargo compile --include-keys doesn't include keys #3488

Closed
signorecello opened this issue Nov 14, 2023 · 2 comments · Fixed by #3692
Closed

nargo compile --include-keys doesn't include keys #3488

signorecello opened this issue Nov 14, 2023 · 2 comments · Fixed by #3692
Assignees
Labels
bug Something isn't working

Comments

@signorecello
Copy link
Contributor

Aim

Tried to include verification keys in the compilation of my circuit

Expected Behavior

For keys to show up in the json file

Bug

They don't show in the json file

To Reproduce

  1. Install Nargo 0.19.2
  2. Run nargo compile --include-keys
  3. Confirm that the keys are absent

Installation Method

Binary

Nargo Version

nargo version = 0.19.2 noirc version = 0.19.2+47f0130c0d154f1b70eb23f376783beb3f23ad72 (git version hash: 47f0130, is dirty: false)

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@signorecello signorecello added the bug Something isn't working label Nov 14, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Nov 14, 2023
@mikirov
Copy link

mikirov commented Dec 4, 2023

I ran into this issue trying to use nargo compile --package <package_name> --include-keys. Not sure if it's related. Nargo version 0.19.4

@guipublic
Copy link
Contributor

In fact keys are not part of the artefacts anymore, cf. #2280
I will remove the include-keys option then.

github-merge-queue bot pushed a commit that referenced this issue Dec 5, 2023
# Description

## Problem\*

Resolves #3488 

## Summary\*

Keys have been removed from the artefacts, so we need to remove the
option to add them as well.

## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [X] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [X] I have tested the changes locally.
- [X] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants