-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify fixed base scalar mul to take in the low and high limbs #2588
Labels
Comments
This was referenced Sep 7, 2023
This was referenced Sep 8, 2023
Merged
kevaundray
added a commit
to AztecProtocol/aztec-packages
that referenced
this issue
Sep 12, 2023
See noir-lang/noir#2588 for more details # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).
AztecBot
pushed a commit
to AztecProtocol/barretenberg
that referenced
this issue
Sep 12, 2023
See noir-lang/noir#2588 for more details # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).
AztecBot
pushed a commit
to AztecProtocol/build-system
that referenced
this issue
Sep 14, 2023
See noir-lang/noir#2588 for more details # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Related to https://github.com/noir-lang/noir/pull/2586/files
The grumpkin modulus is larger than the bn254 modulus, so when we do a grumpkin scalar multiplication we need to split the grumpkin scalar into multiple bn254 scalars.
Our method for doing scalar multiplication in the backend however only takes one Field.
Happy Case
Short term
This method should take two limbs because it takes two bn254 field elements to fully represent a grumpkin field element.
Long term
This should be generic enough to account for the differences in the modulus' of both curves being used
Alternatives Considered
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered: