Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dep keyword for importing from dependencies #2307

Closed
jfecher opened this issue Aug 14, 2023 · 2 comments · Fixed by #4946
Closed

Remove dep keyword for importing from dependencies #2307

jfecher opened this issue Aug 14, 2023 · 2 comments · Fixed by #4946
Assignees
Labels
enhancement New feature or request

Comments

@jfecher
Copy link
Contributor

jfecher commented Aug 14, 2023

Problem

Importing from libraries in Noir differs from rust in that you must add a dep:: prefix to each path in the dependency. This is unnecessary since you can already tell by the crate name in the path that it is a different crate.

Happy Case

The dep:: prefix is removed.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@jfecher jfecher added enhancement New feature or request P-LOW labels Aug 14, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 14, 2023
@jfecher jfecher self-assigned this Aug 14, 2023
@kevaundray
Copy link
Contributor

@jfecher did you start working on this? If not, then I think we can assign it to someone else to reduce context switch and since its E-LOW

@jfecher
Copy link
Contributor Author

jfecher commented Aug 17, 2023

@kevaundray I haven't

@TomAFrench TomAFrench assigned michaeljklein and unassigned jfecher Apr 21, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 17, 2024
# Description

## Problem\*

Resolves #2307

## Summary\*

`dep::` is unnecessary to distinguish between internal and external
crates, so this PR removes it.

## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Tom French <[email protected]>
Co-authored-by: Tom French <[email protected]>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants