Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): Add a codelens that runs test when clicked #1835

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Jun 28, 2023

Description

Problem*

First implementation of #1834

Summary*

This adds the infrastructure to display codelenses via the LSP. The first codelens that we support is the > Run Test action above functions marked via #[test]. The lens will display in any version of the vscode extension, but there is no command registered for nargo.test in the currently released version. We are adding the nargo.test command in noir-lang/vscode-noir#25 (you can package it into a vsix and install manually to try).

Screenshot 2023-06-28 at 4 00 05 PM

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

@kobyhallx kobyhallx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kevaundray kevaundray added this pull request to the merge queue Jun 29, 2023
Merged via the queue into master with commit 5d64f8a Jun 29, 2023
@kevaundray kevaundray deleted the phated/codelens-run-test branch June 29, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants