Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use to_expression in Acir Gen to conveniently convert AcirVarData into an Expression #1441

Closed
Tracked by #1376
kevaundray opened this issue May 30, 2023 · 0 comments · Fixed by #1658
Closed
Tracked by #1376

Use to_expression in Acir Gen to conveniently convert AcirVarData into an Expression #1441

kevaundray opened this issue May 30, 2023 · 0 comments · Fixed by #1658
Labels
enhancement New feature or request refactor ssa

Comments

@kevaundray
Copy link
Contributor

Problem

Related PR and comment #1430 (comment)

Happy Case

.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@kevaundray kevaundray added the enhancement New feature or request label May 30, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir May 30, 2023
@kevaundray kevaundray mentioned this issue May 30, 2023
Merged
kevaundray added a commit that referenced this issue May 30, 2023
@kevaundray
remove TODO See: Use to_expression in Acir Gen to conveniently conv…
f3745a3 
…ert `AcirVarData` into an `Expression` #1441
kevaundray added a commit that referenced this issue May 30, 2023
@kevaundray @joss-aztec
chore(ssa refactor): Add code to handle assert statement in acir gen (#…
401dd1d 
…1430)

* add field mul and div

* add code to process field mul and div

* add assert example

* add `is_equal` constraint

* add `eq_var` method for AcirVar

* process `Constrain` instruction and BinaryOp::Eq

* Update crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/generated_acir.rs

Co-authored-by: joss-aztec <[email protected]>

* fixup comment

* remove TODO See:  Use `to_expression` in Acir Gen to conveniently convert `AcirVarData` into an `Expression` #1441

---------

Co-authored-by: joss-aztec <[email protected]>
@Savio-Sou Savio-Sou mentioned this issue Jun 2, 2023
Closed
@joss-aztec joss-aztec mentioned this issue Jun 13, 2023
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactor ssa
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ssa refactor): simplify acir_variable using to_expression noir-lang/noir
1 participant
@kevaundray