Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all tests to use assert instead of constrain #1251

Closed
1 task done
kevaundray opened this issue Apr 28, 2023 · 6 comments · Fixed by #1276
Closed
1 task done

Change all tests to use assert instead of constrain #1251

kevaundray opened this issue Apr 28, 2023 · 6 comments · Fixed by #1276
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kevaundray
Copy link
Contributor

Problem

Now that we are moving towards assert instead of constrain . We should modify our examples to use assert.

The examples live here

Proposed solution

In each example, rename constrain expr to be assert(expr).

Note: There is an assert example which uses the assert keyword instead of `constrain.

Alternatives considered

No response

Additional context

No response

Submission Checklist

  • Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.
@kevaundray kevaundray added enhancement New feature or request good first issue Good for newcomers labels Apr 28, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Apr 28, 2023
@kevaundray
Copy link
Contributor Author

@makluganteng This is a good first issue, if you are interested :)

@makluganteng
Copy link

Yup i can take this task

@makluganteng
Copy link

makluganteng commented Apr 29, 2023

@kevaundray Hi, i kinda need help on setting up the env so that i could test it out. I cant seem to get in the discord either.

@shivamganwani
Copy link

@makluganteng which point are you stuck at?

@makluganteng
Copy link

when im installing the direnv. nix --extra-experimental-features install nixpkgs#direnv

@kevaundray
Copy link
Contributor Author

Hi @makluganteng ,

Thank you for the willingness to take up this task -- I'm going to re-assign this issue to someone on the team. If you are still having installation problems, please open up an issue for it and flag it on our discourse: https://discourse.aztec.network/c/noir/7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants