-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation warning for constrain
#1228
Comments
I'm guessing the scope of this task includes removing all stdlib usages of constrain, since otherwise the user has to tolerate a ton of warnings. |
Linking #1251 to this issue as as Joss says, we need to address it first. |
Ah, we're in a bit of a tangle. They won't be able to fix the tests without fixing stldlib. Should I back my stdlib changes out, and leave that to the scope of #1275? |
Oh actually that's not true, because they won't encounter the depreciation warning because it's not merged yet 😅. It's just my PR that's blocked since the tests won't pass. |
Problem
As of #1227 we are deprecating
constrain
forassert
. Since we don't want to break all existing Noir programs, we will for now just add a deprecation warning whenever constrain is used to tell folks to useassert
.Proposed solution
Add deprecation warning
Alternatives considered
No response
Additional context
No response
Submission Checklist
The text was updated successfully, but these errors were encountered: