Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor circuit_build_path logic #1201

Closed
1 task done
phated opened this issue Apr 21, 2023 · 1 comment · Fixed by #1992
Closed
1 task done

Refactor circuit_build_path logic #1201

phated opened this issue Apr 21, 2023 · 1 comment · Fixed by #1992
Labels
discussion enhancement New feature or request

Comments

@phated
Copy link
Contributor

phated commented Apr 21, 2023

Problem

The logic for getting a circuit_build_path or recompiling is duplicated many times throughout nargo_cli. This should be refactored.

Proposed solution

Per @TomAFrench's comment:

I'd like to add a "context" struct at some point which essentially wraps the PackageManifest along with the package's root directory. These sorts of functions would then live as methods on there.

Alternatives considered

No response

Additional context

No response

Submission Checklist

  • Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.
@vicyyn
Copy link

vicyyn commented Jun 3, 2023

Hello! would love to work on this issue. is there more context on how I would implement this? Thank you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants