feat!: Switch to aztec_backend that uses upstream BB & UltraPlonk #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added to nargo test_data
phated
commented
Apr 10, 2023
phated
commented
Apr 10, 2023
phated
commented
Apr 10, 2023
phated
commented
Apr 10, 2023
phated
commented
Apr 10, 2023
phated
commented
Apr 10, 2023
kevaundray
reviewed
Apr 21, 2023
kevaundray
reviewed
Apr 21, 2023
kevaundray
reviewed
Apr 21, 2023
6 tasks
TomAFrench
previously approved these changes
Apr 21, 2023
vezenovm
previously approved these changes
Apr 21, 2023
kevaundray
previously approved these changes
Apr 21, 2023
phated
dismissed stale reviews from kevaundray, vezenovm, and TomAFrench
via
ab9e8c3
kevaundray
approved these changes
Apr 21, 2023
TomAFrench
added a commit
that referenced
this pull request
Apr 24, 2023
* master: chore: update flake version to match current release (#1204) feat!: Switch to aztec_backend that uses upstream BB & UltraPlonk (#1114) chore(ssa refactor): Add Context structs and start ssa gen pass (#1196) chore(ssa): Replace JmpIf with BrIf (#1193) chore(noir): Release 0.4.1 (#1164) chore(ssa refactor): Add DenseMap and SparseMap types (#1184) feat: bump noir-source-resolver version (#1182) chore(deps): bump h2 from 0.3.16 to 0.3.18 (#1186) fix(nargo): restore `nargo codegen-verifier` functionality (#1185) chore: simplify setup code in `noir_integration` test (#1180) feat: Add Poseidon-BN254 hash functions (#1176)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #991
Resolves #1001
Resolves #1105
Resolves #1115
Description
This updates the
aztec_backenddependencies to the latest commit, which has started depending on upstream barretenberg and switches to UltraPlonk.Since BB has a lot of dependencies to be built, @kobyhallx and I have added a Nix flake to the repository to manage this dependency.
I've updated the workflows to use Nix to run clippy and cargo tests.
This is currently a draft because more work needs to be done to update values in the tests, and it seems that there is a CRS bug in BB because we are getting a panic when trying to run the prove_and_verify tests. Will need to work with @vezenovm and @kevaundray to sort that out.
Summary of changes
Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context
Docs updates:
nix profile install ...to install nargo globally)