Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests from nargo/test/test_data to nargo_cli #1124

Closed
1 task done
kevaundray opened this issue Apr 9, 2023 · 5 comments · Fixed by #1257
Closed
1 task done

Move tests from nargo/test/test_data to nargo_cli #1124

kevaundray opened this issue Apr 9, 2023 · 5 comments · Fixed by #1257
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

Tests were moved to nargo_cli, however there are two poseidon tests in the nargo/tests

Proposed solution

Move tests to nargo_cli/tests

Alternatives considered

No response

Additional context

No response

Submission Checklist

  • Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.
@kevaundray kevaundray added the enhancement New feature or request label Apr 9, 2023
@kevaundray kevaundray added this to Noir Apr 9, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Apr 9, 2023
@phated
Copy link
Contributor

phated commented Apr 13, 2023

I done this in #1114 because I wanted to make sure all tests were passing. Note that the directory structure might exist on your computer if you've cloned the project before because the Verifier.toml files are gitignored.

@phated phated assigned phated and unassigned joss-aztec Apr 13, 2023
@phated phated moved this from 📋 Backlog to 🏗 In progress in Noir Apr 13, 2023
@phated phated linked a pull request Apr 13, 2023 that will close this issue
6 tasks
@kevaundray
Copy link
Contributor Author

The poseidon tests are not passing -- they seemed like they were before because we moved tests to nargo_cli and they stopped running since they were located in nargo/test_data

@phated
Copy link
Contributor

phated commented Apr 13, 2023

Due to the above ☝️ I've backed out the changes in 1114 as this will need to be a bigger fix.

@phated phated removed their assignment Apr 13, 2023
@phated phated moved this from 🏗 In progress to 📋 Backlog in Noir Apr 13, 2023
@joss-aztec
Copy link
Contributor

In the case of the test poseidonperm_x5_254, it's the usage of pow_32 in permute that results in barretenberg emitting the linear_eval is not 0. error that's been seen on other broken proofs issues:
#1134
#1045

@kevaundray
Copy link
Contributor Author

Tracking issue : #1252

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants