IncrementRC has no side effects?

noir-lang · Nov 28, 2023 · fcc90db · fcc90db
1 parent 7a08d1d
commit fcc90db
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/compiler/noirc_evaluator/src/ssa/ir/instruction.rs b/compiler/noirc_evaluator/src/ssa/ir/instruction.rs
@@ -275,10 +275,15 @@ impl Instruction {
             | ArrayGet { .. }
             | ArraySet { .. } => false,
 
+            // IncrementRc is not counted as having side effects since we still
+            // want it to be removed by the DIE pass if its parameter is unused.
+            // At the time of writing has_side_effects is only used by DIE but
+            // we should keep this in mind (or rename this method?) if it is ever used elsewhere.
+            IncrementRc { .. } => false,
+
             Constrain(..)
             | Store { .. }
             | EnableSideEffects { .. }
-            | IncrementRc { .. }
             | RangeCheck { .. } => true,
 
             // Some `Intrinsic`s have side effects so we must check what kind of `Call` this is.