Merge branch 'master' into aztec-packages

* master: (39 commits) chore: remove unwanted prints (#4419) fix: remove print from monomorphization pass (#4417) chore(ssa): Remove mem2reg run before flattening (#4415) feat: Add HashMap to the stdlib (#4242) fix!: Ban Fields in for loop indices and bitwise ops (#4376) chore: Add #[recursive] Explainer to Documentation (#4399) feat(ci): Use wasm-opt when compiling wasm packages (#4334) fix: add handling to `noir_wasm` for projects without dependencies (#4344) chore: rename parameter 'filter' to 'level' in 'init_log_level' (#4403) chore!: bump msrv to 1.73.0 (#4406) chore: fix docker test workflows (#4308) chore: Update Vec docs (#4400) feat: update error message when trying to load workspace as dependency (#4393) chore: bump webpack dependencies (#4346) fix: correct invalid brillig codegen for `EmbeddedCurvePoint.add` (#4382) chore: remove dependency on generational-arena (#4207) fix(docs): update install versions (#4396) fix: Enforce matching types of binary ops in SSA (#4391) fix(docs): Update noirjs_app for 0.23 (#4378) chore(ci): add alerts for failed publishes (#4388) ...
noir-lang · Feb 26, 2024 · fac5770 · fac5770
2 parents b93d45f + 3386067
commit fac5770
Show file tree

Hide file tree

Showing 155 changed files with 3,476 additions and 1,280 deletions.
diff --git a/.github/CRATES_IO_PUBLISH_FAILED.md b/.github/CRATES_IO_PUBLISH_FAILED.md
@@ -0,0 +1,10 @@
+---
+title: "ACVM crates failed to publish"
+assignees: TomAFrench kevaundray savio-sou
+---
+
+The {{env.CRATE_VERSION}} release of the ACVM crates failed.
+
+Check the [Publish ACVM]({{env.WORKFLOW_URL}}) workflow for details.
+
+This issue was raised by the workflow `{{env.WORKFLOW_NAME}}`
diff --git a/.github/EXTERNAL_CONTRIBUTOR_PR_COMMENT.md b/.github/EXTERNAL_CONTRIBUTOR_PR_COMMENT.md
@@ -0,0 +1,5 @@
+Thank you for your contribution to the Noir language.
+
+Please **do not force push to this branch** after the Noir team have reviewed this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch.
+
+Thanks for your understanding.
diff --git a/.github/JS_PUBLISH_FAILED.md b/.github/JS_PUBLISH_FAILED.md
@@ -0,0 +1,11 @@
+---
+title: "JS packages failed to publish"
+assignees: TomAFrench kevaundray savio-sou
+labels: js
+---
+
+The {{env.NPM_TAG}} release of the JS packages failed.
+
+Check the [Publish JS packages]({{env.WORKFLOW_URL}}) workflow for details.
+
+This issue was raised by the workflow `{{env.WORKFLOW_NAME}}`
diff --git a/.github/actions/setup/action.yml b/.github/actions/setup/action.yml
@@ -7,7 +7,7 @@ runs:
     - uses: actions/setup-node@v4
       id: node
       with:
-        node-version: 18.17.1
+        node-version: 18.19.0
         cache: 'yarn'
         cache-dependency-path: 'yarn.lock'
 

diff --git a/.github/scripts/integration-test-browser.sh b/.github/scripts/integration-test-browser.sh
@@ -2,4 +2,4 @@
 set -eu
 
 ./.github/scripts/playwright-install.sh
-yarn workspace integration-tests test
+yarn workspace integration-tests test:browser
diff --git a/.github/scripts/integration-test-node.sh b/.github/scripts/integration-test-node.sh
@@ -2,4 +2,4 @@
 set -eu
 
 apt-get install libc++-dev -y
-yarn workspace integration-tests test
+yarn workspace integration-tests test:node
diff --git a/.github/scripts/wasm-opt-install.sh b/.github/scripts/wasm-opt-install.sh
@@ -0,0 +1,8 @@
+#!/bin/bash
+set -eu
+
+cd $(dirname "$0")
+
+./cargo-binstall-install.sh
+
+cargo-binstall wasm-opt --version 0.116.0 -y
diff --git a/.github/workflows/docs-pr.yml b/.github/workflows/docs-pr.yml
@@ -55,7 +55,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.71.1
+        uses: dtolnay/rust-toolchain@1.73.0
 
       - uses: Swatinem/rust-cache@v2
         with:
@@ -114,3 +114,16 @@ jobs:
           NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
           NETLIFY_SITE_ID: ${{ secrets.NETLIFY_SITE_ID }}
         timeout-minutes: 1
+
+  add_comment:
+    needs: [deploy_preview]
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+    steps:
+      - name: Tag dev rel in comment
+        uses: marocchino/sticky-pull-request-comment@v2
+        with:
+          message: |
+            FYI @noir-lang/developerrelations on Noir doc changes.
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.github/workflows/formatting.yml b/.github/workflows/formatting.yml
@@ -32,7 +32,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.71.1
+        uses: dtolnay/rust-toolchain@1.73.0
         with:
           targets: ${{ matrix.target }}
           components: clippy, rustfmt

diff --git a/.github/workflows/gates_report.yml b/.github/workflows/gates_report.yml
@@ -18,7 +18,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.71.1
+        uses: dtolnay/rust-toolchain@1.73.0
 
       - uses: Swatinem/rust-cache@v2
         with:

diff --git a/.github/workflows/publish-acvm.yml b/.github/workflows/publish-acvm.yml
@@ -18,7 +18,7 @@ jobs:
           ref: ${{ inputs.noir-ref }}
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.71.1
+        uses: dtolnay/rust-toolchain@1.73.0
 
       # These steps are in a specific order so crate dependencies are updated first
       - name: Publish acir_field
@@ -62,3 +62,16 @@ jobs:
           cargo publish --package acvm
         env:
           CARGO_REGISTRY_TOKEN: ${{ secrets.ACVM_CRATES_IO_TOKEN }}
+
+      # Raise an issue if any package failed to publish
+      - name: Alert on failed publish
+        uses: JasonEtco/create-an-issue@v2
+        if: ${{ failure() }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          CRATE_VERSION: ${{ inputs.noir-ref }}
+          WORKFLOW_NAME: ${{ github.workflow }}
+          WORKFLOW_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
+        with:
+          update_existing: true
+          filename: .github/JS_PUBLISH_FAILED.md
diff --git a/.github/workflows/publish-es-packages.yml b/.github/workflows/publish-es-packages.yml
@@ -22,7 +22,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.71.1
+        uses: dtolnay/rust-toolchain@1.73.0
 
       - uses: Swatinem/rust-cache@v2
         with:
@@ -32,6 +32,9 @@ jobs:
       - name: Install Yarn dependencies
         uses: ./.github/actions/setup
 
+      - name: Install wasm-opt
+        run: ./.github/scripts/wasm-opt-install.sh
+
       - name: Build noirc_abi
         run: ./.github/scripts/noirc-abi-build.sh
 
@@ -51,7 +54,7 @@ jobs:
           ref: ${{ inputs.noir-ref }}
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.71.1
+        uses: dtolnay/rust-toolchain@1.73.0
 
       - uses: Swatinem/rust-cache@v2
         with:
@@ -61,6 +64,9 @@ jobs:
       - name: Install Yarn dependencies
         uses: ./.github/actions/setup
 
+      - name: Install wasm-opt
+        run: ./.github/scripts/wasm-opt-install.sh
+
       - name: Build noir_js_types
         run: yarn workspace @noir-lang/types build
 
@@ -83,7 +89,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.71.1
+        uses: dtolnay/rust-toolchain@1.73.0
 
       - uses: Swatinem/rust-cache@v2
         with:
@@ -93,6 +99,9 @@ jobs:
       - name: Install Yarn dependencies
         uses: ./.github/actions/setup
 
+      - name: Install wasm-opt
+        run: ./.github/scripts/wasm-opt-install.sh
+
       - name: Build acvm_js
         run: ./.github/scripts/acvm_js-build.sh
 
@@ -114,7 +123,7 @@ jobs:
 
       - uses: actions/download-artifact@v4
         with:
-          name: acvm_js
+          name: acvm-js
           path: acvm-repo/acvm_js
 
       - uses: actions/download-artifact@v4
@@ -143,3 +152,16 @@ jobs:
 
       - name: Publish ES Packages
         run: yarn publish:all --access public --tag ${{ inputs.npm-tag }}
+
+      # Raise an issue if any package failed to publish
+      - name: Alert on failed publish
+        uses: JasonEtco/create-an-issue@v2
+        if: ${{ failure() }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          NPM_TAG: ${{ inputs.npm-tag }}
+          WORKFLOW_NAME: ${{ github.workflow }}
+          WORKFLOW_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
+        with:
+          update_existing: true
+          filename: .github/JS_PUBLISH_FAILED.md
diff --git a/.github/workflows/publish-nargo.yml b/.github/workflows/publish-nargo.yml
@@ -46,7 +46,7 @@ jobs:
           echo "MACOSX_DEPLOYMENT_TARGET=$(xcrun -sdk macosx$(sw_vers -productVersion) --show-sdk-platform-version)" >> $GITHUB_ENV
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.71.1
+        uses: dtolnay/rust-toolchain@1.73.0
         with:
           targets: ${{ matrix.target }}
 
@@ -120,7 +120,7 @@ jobs:
           ref: ${{ inputs.tag || env.GITHUB_REF }}
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.71.1
+        uses: dtolnay/rust-toolchain@1.73.0
         with:
           targets: ${{ matrix.target }}
 

diff --git a/.github/workflows/pull-request-title.yml b/.github/workflows/pull-request-title.yml
@@ -27,3 +27,18 @@ jobs:
             fix
             feat
             chore
+
+  force-push-comment:
+    name: Warn external contributors about force-pushing
+    runs-on: ubuntu-latest
+    if: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.repo.full_name != 'noir-lang/noir' }} 
+    permissions:
+      pull-requests: write
+
+    steps:
+      - name: Post comment on force pushes
+        uses: marocchino/sticky-pull-request-comment@v2
+        with:
+          path: ./.github/EXTERNAL_CONTRIBUTOR_PR_COMMENT.md
+
+
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -45,7 +45,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 18.17.1
+          node-version: 18.19.0
           cache: 'yarn'
           cache-dependency-path: 'yarn.lock'
 

diff --git a/.github/workflows/test-js-packages.yml b/.github/workflows/test-js-packages.yml
@@ -22,7 +22,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.71.1
+        uses: dtolnay/rust-toolchain@1.73.0
 
       - uses: Swatinem/rust-cache@v2
         with:
@@ -55,7 +55,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.71.1
+        uses: dtolnay/rust-toolchain@1.73.0
 
       - uses: Swatinem/rust-cache@v2
         with:
@@ -66,6 +66,9 @@ jobs:
       - name: Install Yarn dependencies
         uses: ./.github/actions/setup
 
+      - name: Install wasm-opt
+        run: ./.github/scripts/wasm-opt-install.sh
+
       - name: Build noirc_abi
         run: ./.github/scripts/noirc-abi-build.sh
 
@@ -86,7 +89,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.71.1
+        uses: dtolnay/rust-toolchain@1.73.0
 
       - uses: Swatinem/rust-cache@v2
         with:
@@ -97,6 +100,9 @@ jobs:
       - name: Install Yarn dependencies
         uses: ./.github/actions/setup
 
+      - name: Install wasm-opt
+        run: ./.github/scripts/wasm-opt-install.sh
+
       - name: Build noir_js_types
         run: yarn workspace @noir-lang/types build
 
@@ -121,7 +127,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.71.1
+        uses: dtolnay/rust-toolchain@1.73.0
 
       - uses: Swatinem/rust-cache@v2
         with:
@@ -132,6 +138,9 @@ jobs:
       - name: Install Yarn dependencies
         uses: ./.github/actions/setup
 
+      - name: Install wasm-opt
+        run: ./.github/scripts/wasm-opt-install.sh
+
       - name: Build acvm_js
         run: ./.github/scripts/acvm_js-build.sh