Skip to content

Commit

Permalink
chore: update condition for clearing warning comment on release PRs (#…
Browse files Browse the repository at this point in the history
…4739)

# Description

## Problem\*

Resolves <!-- Link to GitHub Issue -->

## Summary\*

This is not triggering correctly atm so I'm switching to a more explicit
syntax.

## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [ ] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
  • Loading branch information
TomAFrench authored Apr 8, 2024
1 parent 753851e commit dbb86ac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ jobs:
# We need to specify the PR on which to make the comment as workflow is triggered by push.
number: ${{ fromJSON(needs.release-please.outputs.release-pr).number }}
# delete the comment in case failures have been fixed
delete: ${{ !env.FAIL }}
delete: ${{ env.FAIL == false }}
message: "The release workflow has not completed successfully. Releasing now will result in a broken release"

- name: Report overall success
Expand Down

0 comments on commit dbb86ac

Please sign in to comment.