Skip to content

Commit

Permalink
chore(docs): fix external contributor force push workflow (#4437)
Browse files Browse the repository at this point in the history
# Description

## Problem\*

Resolves #

## Summary\*

This workflow was failing due to the fact that we're storing the message
in a file but not checking out the repository.

While checking out would be safe in this case, I've just moved the
comment into the workflow for paranoia reasons.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
  • Loading branch information
TomAFrench authored Feb 27, 2024
1 parent b9384fb commit 8f935af
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
5 changes: 0 additions & 5 deletions .github/EXTERNAL_CONTRIBUTOR_PR_COMMENT.md

This file was deleted.

6 changes: 5 additions & 1 deletion .github/workflows/pull-request-title.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ jobs:
- name: Post comment on force pushes
uses: marocchino/sticky-pull-request-comment@v2
with:
path: ./.github/EXTERNAL_CONTRIBUTOR_PR_COMMENT.md
message: |
Thank you for your contribution to the Noir language.
Please **do not force push to this branch** after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch.
Thanks for your understanding.

0 comments on commit 8f935af

Please sign in to comment.