chore: restrict visibility of pub functions in noirc_frontend (#975)

chore: restrict visibility of pub functions

crates/noirc_frontend/src/hir/resolution/resolver.rs

@@ -1451,7 +1451,7 @@ mod test {
     }
 
     impl TestPathResolver {
-        pub fn insert_func(&mut self, name: String, func_id: FuncId) {
+        fn insert_func(&mut self, name: String, func_id: FuncId) {
             self.0.insert(name, func_id.into());
         }
     }

crates/noirc_frontend/src/hir/type_check/errors.rs

@@ -1,5 +1,5 @@
 use noirc_errors::CustomDiagnostic as Diagnostic;
-pub use noirc_errors::Span;
+use noirc_errors::Span;
 use thiserror::Error;
 
 use crate::hir_def::expr::HirBinaryOp;

crates/noirc_frontend/src/hir/type_check/expr.rs

@@ -487,7 +487,7 @@ fn bind_function_type(
     }
 }
 
-pub fn prefix_operand_type_rules(op: &crate::UnaryOp, rhs_type: &Type) -> Result<Type, String> {
+fn prefix_operand_type_rules(op: &crate::UnaryOp, rhs_type: &Type) -> Result<Type, String> {
     match op {
         crate::UnaryOp::Minus => {
             if !matches!(rhs_type, Type::Integer(..) | Type::Error) {
@@ -505,7 +505,7 @@ pub fn prefix_operand_type_rules(op: &crate::UnaryOp, rhs_type: &Type) -> Result
 
 // Given a binary operator and another type. This method will produce the output type
 // XXX: Review these rules. In particular, the interaction between integers, comptime and private/public variables
-pub fn infix_operand_type_rules(
+fn infix_operand_type_rules(
     lhs_type: &Type,
     op: &HirBinaryOp,
     rhs_type: &Type,
@@ -689,7 +689,7 @@ fn check_constructor(
     Type::Struct(typ, generics)
 }
 
-pub fn check_member_access(
+fn check_member_access(
     access: expr::HirMemberAccess,
     interner: &mut NodeInterner,
     expr_id: ExprId,
@@ -727,7 +727,7 @@ pub fn check_member_access(
     Type::Error
 }
 
-pub fn comparator_operand_type_rules(
+fn comparator_operand_type_rules(
     lhs_type: &Type,
     rhs_type: &Type,
     op: &HirBinaryOp,

crates/noirc_frontend/src/hir/type_check/mod.rs

@@ -245,7 +245,7 @@ mod test {
     }
 
     impl TestPathResolver {
-        pub fn insert_func(&mut self, name: String, func_id: FuncId) {
+        fn insert_func(&mut self, name: String, func_id: FuncId) {
             self.0.insert(name, func_id.into());
         }
     }

crates/noirc_frontend/src/hir/type_check/stmt.rs

@@ -60,7 +60,7 @@ pub(crate) fn type_check(
 
 /// Associate a given HirPattern with the given Type, and remember
 /// this association in the NodeInterner.
-pub fn bind_pattern(
+pub(crate) fn bind_pattern(
     interner: &mut NodeInterner,
     pattern: &HirPattern,
     typ: Type,

crates/noirc_frontend/src/lib.rs

@@ -7,6 +7,7 @@
 //! perform optimizations, convert to ACIR and eventually prove/verify the program.
 #![forbid(unsafe_code)]
 #![warn(unused_crate_dependencies, unused_extern_crates)]
+#![warn(unreachable_pub)]
 
 pub mod ast;
 pub mod graph;