chore: remove unnecessary cloning of package dependencies (#2175)

noir-lang · Aug 4, 2023 · 295d82e · 295d82e
1 parent 186375b
commit 295d82e
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/crates/nargo_cli/src/lib.rs b/crates/nargo_cli/src/lib.rs
@@ -102,14 +102,14 @@ fn list_files_and_folders_in<P: AsRef<Path>>(path: P) -> Option<ReadDir> {
 fn prepare_dependencies(
     context: &mut Context,
     parent_crate: CrateId,
-    dependencies: BTreeMap<CrateName, Dependency>,
+    dependencies: &BTreeMap<CrateName, Dependency>,
 ) {
-    for (dep_name, dep) in dependencies.into_iter() {
+    for (dep_name, dep) in dependencies.iter() {
         match dep {
             Dependency::Remote { package } | Dependency::Local { package } => {
                 let crate_id = prepare_crate(context, &package.entry_path, package.crate_type);
-                add_dep(context, parent_crate, crate_id, dep_name);
-                prepare_dependencies(context, crate_id, package.dependencies.to_owned());
+                add_dep(context, parent_crate, crate_id, dep_name.clone());
+                prepare_dependencies(context, crate_id, &package.dependencies);
             }
         }
     }
@@ -122,7 +122,7 @@ fn prepare_package(package: &Package) -> (Context, CrateId) {
 
     let crate_id = prepare_crate(&mut context, &package.entry_path, package.crate_type);
 
-    prepare_dependencies(&mut context, crate_id, package.dependencies.to_owned());
+    prepare_dependencies(&mut context, crate_id, &package.dependencies);
 
     (context, crate_id)
 }