Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary generic #42

Merged
merged 2 commits into from
Nov 1, 2024
Merged

fix: remove unnecessary generic #42

merged 2 commits into from
Nov 1, 2024

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves #41

Summary*

This generic is unnecessary and just causes errors when it can't be bound.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from kashbrti October 31, 2024 13:36
@TomAFrench TomAFrench mentioned this pull request Oct 31, 2024
Merged
2 tasks
@TomAFrench TomAFrench enabled auto-merge (squash) October 31, 2024 18:02
kashbrti
kashbrti approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@kashbrti kashbrti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generics are not used in the functions at all so can be removed.

@TomAFrench TomAFrench merged commit 1eb64aa into main Nov 1, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Merged
@kashbrti
Copy link
Contributor

kashbrti commented Nov 1, 2024

this might affect changes done in Charlie's branch

@TomAFrench TomAFrench deleted the tf/fix-unnecessary-generic branch November 1, 2024 10:34
TomAFrench added a commit that referenced this pull request Nov 1, 2024
@TomAFrench
Merge branch 'main' into cl/unique_test_names
260116a 
* main:
  fix: remove unnecessary generic (#42)
  migration notes (#38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashbrti kashbrti kashbrti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests fail on latest Nargo nightly release
2 participants
@TomAFrench @kashbrti