Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

feat(acir)!: Remove Oracle opcode #368

Merged
merged 8 commits into from
Jun 21, 2023
Merged

feat(acir)!: Remove Oracle opcode #368

merged 8 commits into from
Jun 21, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves #298

Summary*

This PR removes the Oracle opcode as it has been superceded by Brillig foreign calls.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

ludamad
ludamad approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm so far

TomAFrench
TomAFrench commented Jun 13, 2023
View reviewed changes
Copy link
Member Author

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not in a huge rush to merge this but it would be good to clean up this tech debt. Made some extra notes for areas we need to update

acvm/src/pwg/mod.rs Outdated Show resolved Hide resolved
acvm/src/pwg/mod.rs Outdated Show resolved Hide resolved
acvm/src/pwg/mod.rs Show resolved Hide resolved
acvm/src/pwg/mod.rs Outdated Show resolved Hide resolved
@TomAFrench TomAFrench mentioned this pull request Jun 16, 2023
Merged
2 tasks
@TomAFrench TomAFrench added this to the v0.16.0 milestone Jun 20, 2023
@TomAFrench TomAFrench marked this pull request as ready for review June 21, 2023 03:52
@TomAFrench
Copy link
Member Author

Marking as ready-for-review as next release will be breaking.

@TomAFrench TomAFrench mentioned this pull request Jun 21, 2023
Closed
@TomAFrench TomAFrench changed the title chore(acir)!: Remove Oracle opcode feat(acir)!: Remove Oracle opcode Jun 21, 2023
@TomAFrench TomAFrench added this pull request to the merge queue Jun 21, 2023
Merged via the queue into master with commit 63354df Jun 21, 2023
@kevaundray kevaundray mentioned this pull request Jun 21, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vezenovm vezenovm vezenovm left review comments

@ludamad ludamad ludamad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

Remove Oracle Opcode
3 participants
@TomAFrench @ludamad @vezenovm