This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
fix(brillig): expand memory with zeroes on store #350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Brillig VM memory was fixed on initialization, which requires to always initialize it with an empty memory of the maximum size allowed.
Summary*
This PR expands the memory dynamically on store with zeroes. In the future we can add a feature of passing a maximum memory on VM creation to limit VM memory for applications where brillig is going to be verified with constrained resources, such as in a VM circuit.
Example
Before:
After:
Additional Context
PR Checklist*
cargo fmt
on default settings.