Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

fix(brillig): expand memory with zeroes on store #350

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Conversation

sirasistant
Copy link
Contributor

Description

Problem*

Brillig VM memory was fixed on initialization, which requires to always initialize it with an empty memory of the maximum size allowed.

Summary*

This PR expands the memory dynamically on store with zeroes. In the future we can add a feature of passing a maximum memory on VM creation to limit VM memory for applications where brillig is going to be verified with constrained resources, such as in a VM circuit.

Example

Before:


After:


Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@sirasistant sirasistant requested review from ludamad and kevaundray June 8, 2023 13:52
@kevaundray kevaundray added this pull request to the merge queue Jun 8, 2023
Merged via the queue into master with commit 4d2dadd Jun 8, 2023
@kevaundray kevaundray mentioned this pull request Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants