Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

fix(acir): add bn254 as default feature flag #240

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Resolves (CI failure)

Description

Summary of changes

We currently can't publish releases as cargo publish builds each package before publication and acir doesn't build without a feature flag being set (this wasn't encountered in real usage as we always set this flag when building in the context of the workspace/noir).

See: https://github.com/noir-lang/acvm/actions/runs/4830288705/jobs/8606331047

This PR sets a default feature flag so that cargo publish can build the acir crate in isolation.

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

@TomAFrench TomAFrench mentioned this pull request Apr 28, 2023
1 task
@kevaundray kevaundray added this pull request to the merge queue Apr 28, 2023
Merged via the queue into master with commit e56973d Apr 28, 2023
@github-actions github-actions bot mentioned this pull request Apr 28, 2023
@TomAFrench TomAFrench deleted the fix-releases branch April 28, 2023 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants