This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
fix(acir): add bn254
as default feature flag
#240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves (CI failure)
Description
Summary of changes
We currently can't publish releases as
cargo publish
builds each package before publication andacir
doesn't build without a feature flag being set (this wasn't encountered in real usage as we always set this flag when building in the context of the workspace/noir).See: https://github.com/noir-lang/acvm/actions/runs/4830288705/jobs/8606331047
This PR sets a default feature flag so that
cargo publish
can build theacir
crate in isolation.Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmt
with default settings.Additional context
(If applicable.)