Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

feat(acir)!: BlackBoxFunc::VerifyProof #234

Closed
wants to merge 5 commits into from
Closed

feat(acir)!: BlackBoxFunc::VerifyProof #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
53ff30f
add VerifyProof BlackBoxFunc
vezenovm Apr 26, 2023
b426295
merge conflicts w/ master
vezenovm Apr 28, 2023
ef2ec72
missing from_u16 for verifyproof
vezenovm Apr 28, 2023
3faac83
proof_as_fields and vk_as_fields
vezenovm May 3, 2023
3c492db
cargo fmt
vezenovm May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 62 additions & 31 deletions acir/src/circuit/black_box_functions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ pub enum BlackBoxFunc {
EcdsaSecp256k1,
FixedBaseScalarMul,
Keccak256,
VerifyProof,
}

impl std::fmt::Display for BlackBoxFunc {
Expand All @@ -46,6 +47,7 @@ impl BlackBoxFunc {
BlackBoxFunc::XOR => 10,
BlackBoxFunc::RANGE => 11,
BlackBoxFunc::Keccak256 => 12,
BlackBoxFunc::VerifyProof => 13,
}
}
pub fn from_u16(index: u16) -> Option<Self> {
Expand All @@ -63,6 +65,7 @@ impl BlackBoxFunc {
10 => BlackBoxFunc::XOR,
11 => BlackBoxFunc::RANGE,
12 => BlackBoxFunc::Keccak256,
13 => BlackBoxFunc::VerifyProof,
_ => return None,
};
Some(function)
Expand All @@ -82,6 +85,7 @@ impl BlackBoxFunc {
BlackBoxFunc::XOR => "xor",
BlackBoxFunc::RANGE => "range",
BlackBoxFunc::Keccak256 => "keccak256",
BlackBoxFunc::VerifyProof => "verify_proof",
}
}
pub fn lookup(op_name: &str) -> Option<BlackBoxFunc> {
Expand All @@ -99,6 +103,7 @@ impl BlackBoxFunc {
"xor" => Some(BlackBoxFunc::XOR),
"range" => Some(BlackBoxFunc::RANGE),
"keccak256" => Some(BlackBoxFunc::Keccak256),
"verify_proof" => Some(BlackBoxFunc::VerifyProof),
_ => None,
}
}
Expand All @@ -112,49 +117,70 @@ impl BlackBoxFunc {
BlackBoxFunc::SHA256 => FuncDefinition {
name,
input_size: InputSize::Variable,
output_size: OutputSize(32),
output_size: OutputSize::Fixed(32),
},
BlackBoxFunc::Blake2s => FuncDefinition {
name,
input_size: InputSize::Variable,
output_size: OutputSize(32),
output_size: OutputSize::Fixed(32),
},
BlackBoxFunc::HashToField128Security => FuncDefinition {
name,
input_size: InputSize::Variable,
output_size: OutputSize::Fixed(1),
},
BlackBoxFunc::ComputeMerkleRoot => FuncDefinition {
name,
input_size: InputSize::Variable,
output_size: OutputSize::Fixed(1),
},
BlackBoxFunc::HashToField128Security => {
FuncDefinition { name, input_size: InputSize::Variable, output_size: OutputSize(1) }
}
BlackBoxFunc::ComputeMerkleRoot => {
FuncDefinition { name, input_size: InputSize::Variable, output_size: OutputSize(1) }
}
BlackBoxFunc::SchnorrVerify => FuncDefinition {
name,
// XXX: input_size can be changed to fixed, once we hash
// the message before passing it to schnorr.
// This is assuming all hashes will be 256 bits. Reasonable?
input_size: InputSize::Variable,
output_size: OutputSize(1),
output_size: OutputSize::Fixed(1),
},
BlackBoxFunc::Pedersen => FuncDefinition {
name,
input_size: InputSize::Variable,
output_size: OutputSize::Fixed(2),
},
BlackBoxFunc::EcdsaSecp256k1 => FuncDefinition {
name,
input_size: InputSize::Variable,
output_size: OutputSize::Fixed(1),
},
BlackBoxFunc::FixedBaseScalarMul => FuncDefinition {
name,
input_size: InputSize::Fixed(1),
output_size: OutputSize::Fixed(2),
},
BlackBoxFunc::AND => FuncDefinition {
name,
input_size: InputSize::Fixed(2),
output_size: OutputSize::Fixed(1),
},
BlackBoxFunc::XOR => FuncDefinition {
name,
input_size: InputSize::Fixed(2),
output_size: OutputSize::Fixed(1),
},
BlackBoxFunc::RANGE => FuncDefinition {
name,
input_size: InputSize::Fixed(1),
output_size: OutputSize::Fixed(0),
},
BlackBoxFunc::Pedersen => {
FuncDefinition { name, input_size: InputSize::Variable, output_size: OutputSize(2) }
}
BlackBoxFunc::EcdsaSecp256k1 => {
FuncDefinition { name, input_size: InputSize::Variable, output_size: OutputSize(1) }
}
BlackBoxFunc::FixedBaseScalarMul => {
FuncDefinition { name, input_size: InputSize::Fixed(1), output_size: OutputSize(2) }
}
BlackBoxFunc::AND => {
FuncDefinition { name, input_size: InputSize::Fixed(2), output_size: OutputSize(1) }
}
BlackBoxFunc::XOR => {
FuncDefinition { name, input_size: InputSize::Fixed(2), output_size: OutputSize(1) }
}
BlackBoxFunc::RANGE => {
FuncDefinition { name, input_size: InputSize::Fixed(1), output_size: OutputSize(0) }
}
BlackBoxFunc::Keccak256 => FuncDefinition {
name,
input_size: InputSize::Variable,
output_size: OutputSize(32),
output_size: OutputSize::Fixed(32),
},
BlackBoxFunc::VerifyProof => FuncDefinition {
name,
input_size: InputSize::Variable,
output_size: OutputSize::Variable,
},
}
}
Expand All @@ -178,10 +204,15 @@ impl InputSize {
}
}

// Output size Cannot currently vary, so we use a separate struct
// XXX: In the future, we may be able to allow the output to vary based on the input size, however this implies support for dynamic circuits
// Descriptor as to whether the output is fixed or variable
// Example: The input and output for recursive verification is variable as different proof systems can have different sized aggregation objects.
// XXX: In the future, we may be able to allow the output to vary based on the input size, however this implies support for dynamic circuits,
// right now any variable output size should be based upon the proving system, not the input size
#[derive(Clone, Debug, Hash, PartialEq, Eq)]
pub struct OutputSize(pub u128);
pub enum OutputSize {
Variable,
Fixed(u128),
}

#[derive(Clone, Debug, Hash)]
// Specs for how many inputs/outputs the method takes.
Expand Down
9 changes: 9 additions & 0 deletions acvm/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ use acir::{
native_types::{Expression, Witness},
BlackBoxFunc,
};
use k256::elliptic_curve::Field;
use pwg::{block::Blocks, directives::solve_directives};
use std::collections::BTreeMap;
use thiserror::Error;
Expand Down Expand Up @@ -236,6 +237,14 @@ pub trait ProofSystemCompiler {
circuit: &Circuit,
verification_key: &[u8],
) -> bool;

fn proof_as_fields(
&self,
proof: &[u8],
public_inputs: BTreeMap<Witness, FieldElement>,
) -> Vec<FieldElement>;

fn vk_as_fields(&self, verification_key: &[u8]) -> (Vec<FieldElement>, FieldElement);
}

/// Supported NP complete languages
Expand Down