Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

feat: implement FieldElement::from<bool>() #203

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

TomAFrench
Copy link
Member

Related issue(s)

(If it does not already exist, first create a GitHub issue that describes the problem this Pull Request (PR) solves before creating the PR and link it here.)

Resolves (link to issue)

Description

Summary of changes

We've got a huge number of instances of this code around multiple codebases so I think it's worth adding a quick way to create a field element to represent a boolean value.

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

@kevaundray kevaundray added this pull request to the merge queue Apr 18, 2023
Merged via the queue into master with commit 476cfa2 Apr 18, 2023
@github-actions github-actions bot mentioned this pull request Apr 18, 2023
@TomAFrench TomAFrench deleted the field-from-bool branch April 18, 2023 14:13
@github-actions github-actions bot mentioned this pull request Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants