This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
feat!: Return entire unresolved Brillig opcode during oracle pause #194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves (link to issue)
Description
The ACVM pauses due to needing oracle outputs. When this was a singular opcode it was fine to simply return this oracle and then the ACVM caller can easily construct the new list of opcodes to be resolved. With Brillig we need the inputs and outputs of the brillig VM itself in order to process the opcode correctly. This PR adds the Brillig opcode as an unresolved opcode when we hit a Brillig oracle pause. This lets the ACVM caller to alter the brillig opcode without knowing or interacting with the encapsulating Brillig opcode's inputs and outputs.
Summary of changes
(Describe the changes in this PR. Point out breaking changes if any.)
Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmt
with default settings.Additional context
(If applicable.)