Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

feat: add optimisations to fallback black box functions on booleans #446

Merged
merged 3 commits into from
Jul 26, 2023
Merged

feat: add optimisations to fallback black box functions on booleans #446

merged 3 commits into from
Jul 26, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR adds special cases to the fallback implementations of logic black box functions. This removes unnecessary an unnecessary toLeRadix directive and the resulting dummy witness which just gets constrained to be equal to an existing witness.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench mentioned this pull request Jul 24, 2023
Closed
@kevaundray kevaundray added this pull request to the merge queue Jul 25, 2023
Merged via the queue into master with commit 2cfb2a8 Jul 26, 2023
@kevaundray kevaundray mentioned this pull request Jul 26, 2023
Merged
@TomAFrench TomAFrench deleted the falback-boolean-optimisation branch July 26, 2023 04:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @kevaundray