chore!: remove unused `OpcodeResolutionError::IncorrectNumFunctionArg…

…uments` variant (#397)
noir-lang · Jun 21, 2023 · d1368d0 · d1368d0
1 parent 63354df
commit d1368d0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/acvm/src/pwg/blackbox/ecdsa.rs b/acvm/src/pwg/blackbox/ecdsa.rs
@@ -45,6 +45,7 @@ pub(super) fn secp256k1_prehashed(
 ) -> Result<OpcodeResolution, OpcodeResolutionError> {
     let hashed_message = to_u8_vec(initial_witness, hashed_message_inputs)?;
 
+    // These errors should never be emitted in practice as they would imply malformed ACIR generation.
     let pub_key_x: [u8; 32] =
         to_u8_vec(initial_witness, public_key_x_inputs)?.try_into().map_err(|_| {
             OpcodeResolutionError::BlackBoxFunctionFailed(

diff --git a/acvm/src/pwg/mod.rs b/acvm/src/pwg/mod.rs
@@ -78,8 +78,6 @@ pub enum OpcodeResolutionError {
     UnsupportedBlackBoxFunc(BlackBoxFunc),
     #[error("could not satisfy all constraints")]
     UnsatisfiedConstrain,
-    #[error("expected {0} inputs for function {1}, but got {2}")]
-    IncorrectNumFunctionArguments(usize, BlackBoxFunc, usize),
     #[error("failed to solve blackbox function: {0}, reason: {1}")]
     BlackBoxFunctionFailed(BlackBoxFunc, String),
     #[error("failed to solve brillig function, reason: {0}")]