Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): run tests from all crates in workspace #13

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

TomAFrench
Copy link
Member

We're currently only running the tests in the default crates in each workspace, e.g. for noir-lang/noir we're not running any tests outside of the nargo crate.

We should definitely be checking the other crates for correctness (realistically we should be pushing test coverage further down so we rely less on expensive integration tests) so I've updated the workflows to run tests for every crate in the workspace.

@phated
Copy link
Contributor

phated commented Feb 17, 2023

@TomAFrench Will this crash when we aren't in a cargo-workspace? These are used in bb_wrapper which isn't a workspace.

@TomAFrench
Copy link
Member Author

Will this crash when we aren't in a cargo-workspace? These are used in bb_wrapper which isn't a workspace.

I can't test on bb_wrapper directly atm (it's not wanting to build despite being on the mainframe), but I've checked in another non-workspace rust project and it worked fine.

Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I tested it in bb_wrapper and it seems to work. I also ran against Noir at https://github.com/noir-lang/noir/actions/runs/4233903932/jobs/7355474590 so I think it's good to go.

@phated phated merged commit be4457f into main Feb 21, 2023
@phated phated deleted the run-all-crate-tests branch February 21, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants