lib: add tracing support for fetch(undici) #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santigimeno
force-pushed
the
santi/undici_fetch_tracing
branch
3 times, most recently
from
e7f8d9c to
4dfb76c
Compare
So we can subscribe to the `flagsUpdated` event to receive notifications when the tracing flags have changed. Use it in the otel/core.js:register() method.
santigimeno
force-pushed
the
santi/undici_fetch_tracing
branch
from
4dfb76c to
319a658
Compare
|
@santigimeno feel free to ping me when the PR is ready to review. |
santigimeno
changed the base branch from
node-v20.x-nsolid-v5.x
to
node-v22.x-nsolid-v5.x
santigimeno
force-pushed
the
santi/undici_fetch_tracing
branch
from
319a658 to
1af3ef0
Compare
santigimeno
force-pushed
the
santi/undici_fetch_tracing
branch
from
2ef62d6 to
924a2d1
Compare
santigimeno
requested review from
juanarbol
and removed request for
trevnorris
RafaelGSS
reviewed
Dec 10, 2024
RafaelGSS
approved these changes
Dec 12, 2024
santigimeno
added a commit
that referenced
this pull request
Dec 16, 2024
PR-URL: #216 Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Dec 16, 2024
So we can subscribe to the `flagsUpdated` event to receive notifications when the tracing flags have changed. Use it in the otel/core.js:register() method. PR-URL: #216 Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Dec 16, 2024
PR-URL: #216 Reviewed-By: Rafael Gonzaga <[email protected]>
|
Landed in e858e0c...f8697d4. |
santigimeno
added a commit
that referenced
this pull request
Jan 3, 2025
PR-URL: #216 Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Jan 3, 2025
So we can subscribe to the `flagsUpdated` event to receive notifications when the tracing flags have changed. Use it in the otel/core.js:register() method. PR-URL: #216 Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Jan 3, 2025
PR-URL: #216 Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
PR-URL: #216 Reviewed-By: Rafael Gonzaga <[email protected]> PR-URL: #245
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
So we can subscribe to the `flagsUpdated` event to receive notifications when the tracing flags have changed. Use it in the otel/core.js:register() method. PR-URL: #216 Reviewed-By: Rafael Gonzaga <[email protected]> PR-URL: #245
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
PR-URL: #216 Reviewed-By: Rafael Gonzaga <[email protected]> PR-URL: #245
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
So we can subscribe to the `flagsUpdated` event to receive notifications when the tracing flags have changed. Use it in the otel/core.js:register() method. PR-URL: #216 Reviewed-By: Rafael Gonzaga <[email protected]> PR-URL: #245
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
So we can subscribe to the `flagsUpdated` event to receive notifications when the tracing flags have changed. Use it in the otel/core.js:register() method. PR-URL: #216 Reviewed-By: Rafael Gonzaga <[email protected]> PR-URL: #245 PR-URL: #269 Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.