-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agents: fix process_start calculation #169
Closed
santigimeno
wants to merge
9
commits into
node-v18.20.4-nsolid-v5.3.3-release
from
santi/fix_process_start_calculation_v18
Closed
agents: fix process_start calculation #169
santigimeno
wants to merge
9
commits into
node-v18.20.4-nsolid-v5.3.3-release
from
santi/fix_process_start_calculation_v18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #148 Reviewed-by: Trevor Norris <[email protected]>
PR-URL: #148 Reviewed-by: Trevor Norris <[email protected]>
On preparation of the incoming `GRPCAgent` that's going to be using them. PR-URL: #151 Reviewed-by: Trevor Norris <[email protected]>
PR-URL: #159 Reviewed-By: Trevor Norris <[email protected]>
Update opentelemetry-cpp gyp build file so it uses the `abseil-cpp` library included in `grpc`. PR-URL: #159 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: #159 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: #152 Reviewed-By: Trevor Norris <[email protected]>
SpanCollector is a class that allows to start collecting spans and report them to a callback function running in a specific uv_loop_t thread. The collector can be configured with a minimum span count and a time interval to report the spans. In addition, the collector can be configured with a transform function that will be applied to the spans before calling the final callback. Use this class to dry the code in the `ZmqAgent` and `OTLPAgent`. PR-URL: #160 Reviewed-By: Trevor Norris <[email protected]>
Apparently, in v18.x `performance::performance_process_start_timestamp` is set later than in v20.x. Create a run-once function which calculcates it the first time is needed.
trevnorris
approved these changes
Aug 21, 2024
trevnorris
pushed a commit
that referenced
this pull request
Aug 21, 2024
Apparently, in v18.x `performance::performance_process_start_timestamp` is set later than in v20.x. Create a run-once function which calculcates it the first time is needed. PR-URL: #169 Reviewed-by: Trevor Norris <[email protected]>
trevnorris
force-pushed
the
node-v18.20.4-nsolid-v5.3.3-release
branch
3 times, most recently
from
August 23, 2024 18:20
0e57da9
to
2ed9b5a
Compare
trevnorris
pushed a commit
that referenced
this pull request
Aug 23, 2024
Apparently, in v18.x `performance::performance_process_start_timestamp` is set later than in v20.x. Create a run-once function which calculcates it the first time is needed. PR-URL: #169 Reviewed-by: Trevor Norris <[email protected]>
trevnorris
force-pushed
the
node-v18.20.4-nsolid-v5.3.3-release
branch
from
August 23, 2024 18:23
2ed9b5a
to
97cd48f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, in v18.x
performance::performance_process_start_timestamp
is set later than in v20.x. Create a run-once function which calculcates it the first time is needed.