Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional timeout #200

Closed
duartemendes opened this issue May 26, 2018 · 1 comment
Closed

Optional timeout #200

duartemendes opened this issue May 26, 2018 · 1 comment
Labels
enhancement

Comments

@duartemendes
Copy link
Contributor

As a client I would like to optout the timeout feature.

Reason is that my action is a request, and this request already has a timeout specified. And I would rather receive the error thrown by the request than the opossum one.

For now, I have been setting the opossum timeout bigger than the request one, but this just doesn't feels right :)
duartemendes added a commit to duartemendes/opossum that referenced this issue May 28, 2018
@duartemendes
feat: optional timeout (nodeshift#200)
fa4e71f
@duartemendes duartemendes mentioned this issue May 28, 2018
Closed
duartemendes added a commit to duartemendes/opossum that referenced this issue Jun 4, 2018
@duartemendes
feat: optional timeout (nodeshift#200)
f6b63b2
lance pushed a commit that referenced this issue Jun 6, 2018
@duartemendes @lance
feat: optional timeout (#200) (#202)
7611d6f 
Makes it so that a circuit can function without ever timing out by providing `false` as the value for `options.timeout`.
@lance
Copy link
Member

lance commented Jun 6, 2018

Fixed in #202

@lance lance closed this as completed Jun 6, 2018
@ghost ghost removed the in progress label Jun 6, 2018
@lholmquist lholmquist mentioned this issue May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lance @duartemendes