feat: adding initial test structure #4
Conversation
|
This initial structure includes github action and jest using |
|
updated the PR adding husky as the second part of adding code consistency from ref arch. |
|
PR updated again with husky flow working |
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [10.x, 12.x, 14.x] |
There was a problem hiding this comment.
@helio-frota some of npcheck's plugins use the Optional Chaining operator (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining) which is only available in node v14+
There was a problem hiding this comment.
thanks for the information. I'll change that 👍
| @@ -17,8 +17,10 @@ | |||
| "npcheck": "index.js" | |||
| }, | |||
| "scripts": { | |||
| "prepare": "husky install", | |||
| "pretest": "eslint --ignore-path .gitignore", | |||
There was a problem hiding this comment.
This is a minor detail (also personal preference I admit) but I think we should stick with the lint naming instead of pretest (e.x npm run lint)
There was a problem hiding this comment.
That is part of the husky flow, the commit will call the test which calls the lint via pretest.
https://github.com/nodeshift/nodejs-reference-architecture/blob/main/docs/development/code-consistency.md#guidance
I keep the "lint:fix" in case dev preference.
We are using --no-colors to make the test pass by avoiding colors to make interference related to PASS FAIL output. Since we transferred the coverage bits to coveralls action seems like we don't need that script anymore. Also the script is broken and seems unused since April #4
No description provided.