Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removes unused broken script #66

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Conversation

helio-frota
Copy link
Member

We are using --no-colors to make the test pass by avoiding
colors to make interference related to PASS FAIL output.

Since we transferred the coverage bits to coveralls action
seems like we don't need that script anymore.

Also the script is broken and seems unused since April
#4

@helio-frota
Copy link
Member Author

Please don't merge.

That is interesting...

this is what happens when we run this script locally

-----------------|---------|----------|---------|---------|-------------------
File             | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
-----------------|---------|----------|---------|---------|-------------------
All files        |   96.22 |    89.47 |    92.5 |   96.55 |                   
 lib             |   88.46 |       85 |   85.71 |   89.04 |                   
  format.js      |   83.33 |      100 |   77.78 |   82.61 | 23-26             
  network.js     |      75 |    77.78 |   66.67 |   76.47 | 8-14              
  npcheck-env.js |     100 |      100 |     100 |     100 |                   
  npm.js         |     100 |      100 |     100 |     100 |                   
  regex.js       |     100 |       50 |     100 |     100 | 8                 
  result.js      |     100 |      100 |     100 |     100 |                   
 plugins         |     100 |    91.07 |     100 |     100 |                   
  archive.js     |     100 |      100 |     100 |     100 |                   
  deprecation.js |     100 |      100 |     100 |     100 |                   
  license.js     |     100 |    91.67 |     100 |     100 | 7                 
  licenseTree.js |     100 |       90 |     100 |     100 | 30                
  maintenance.js |     100 |      100 |     100 |     100 |                   
  support.js     |     100 |    78.57 |     100 |     100 | 32-41,56          
  typings.js     |     100 |      100 |     100 |     100 |                   
-----------------|---------|----------|---------|---------|-------------------

Test Suites: 1 failed, 12 passed, 13 total
Tests:       3 failed, 58 passed, 61 total
Snapshots:   0 total
Time:        2.577 s
Ran all test suites.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] coverage: `jest --coverage`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] coverage script.

I'm going to add the --no-color to this instead of remove, since that is required on the CI then is better to have it working both locally and CI envs.

We are using --no-colors to make the test pass by avoiding
colors to make interference related to PASS FAIL output.

Since we transferred the coverage bits to coveralls action
and the coverage script still in the package.json, then
maybe is good to have that working also locally to avoid
confusion.
@helio-frota helio-frota force-pushed the remove-unused-script branch from 13f33eb to d972bca Compare August 26, 2021 16:49
@helio-frota
Copy link
Member Author

also commit message updated: d972bca 👍

@helio-frota helio-frota merged commit d972bca into main Aug 26, 2021
@helio-frota helio-frota deleted the remove-unused-script branch August 26, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants