Fix sending UDP response using new SDK 1.4.0 #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe we might need the same fix over in enduser_setup.c too then. @robertfoss do you want to weigh in? |
jmattsson
pushed a commit
that referenced
this pull request
Nov 11, 2015
Fix sending CoAP UDP response using new SDK 1.4.0
|
PS. Duurrrhh. Johny fixed this a month ago. |
|
jmattson: Having a look. |
robertfoss
added a commit
to robertfoss/nodemcu-firmware
that referenced
this pull request
Nov 12, 2015
…ket, to fix SDK 1.4.0 compability.
jmattsson
pushed a commit
that referenced
this pull request
Nov 17, 2015
Added fix from #750, to access the IP of a sender of a UDP packet, to fix SDK 1.4.0 compability.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From release notes of new SDK
Modify the espconn pointer in the receive callback of UDP. Parameters remote_ip and remote_port in it are the remote IP and port set by espconn_create. If users want to obtain IP and ports of the current sender, please call espconn_get_connection_info to get relevant information.This it copy paste from net module: https://github.com/nodemcu/nodemcu-firmware/blob/dev/app/modules/net.c#L1080-L1088