Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update function wifi.sleep #731

Merged
merged 2 commits into from
Nov 11, 2015
Merged

Conversation

dnc40085
Copy link
Contributor

@dnc40085 dnc40085 commented Nov 5, 2015

Update function wifi.sleep to return any error codes to user and improve code readability

@dnc40085 dnc40085 mentioned this pull request Nov 5, 2015
{
FLAG_wifi_force_sleep_enabled = TRUE;
}
else if (wifi_fpm_do_sleep_return_value != 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, this should probably be a plain "else", not an "else if".

Remove unnecessary code
@jmattsson
Copy link
Member

This is looking fine to me. I will merge unless someone objects.

@jmattsson jmattsson self-assigned this Nov 9, 2015
vowstar added a commit that referenced this pull request Nov 11, 2015
@vowstar vowstar merged commit 63fad19 into nodemcu:dev Nov 11, 2015
@dnc40085 dnc40085 deleted the dev_wifi_sleep_update branch December 22, 2015 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants