New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto create release.yml #3639

Merged

marcelstoer merged 1 commit into nodemcu:dev from HHHartmann:Fix_AutoCreateRelease.yml

Feb 25, 2024

Member

HHHartmann commented Feb 24, 2024 •

edited

Loading

Fixes #<GITHUB_ISSUE_NUMBER>.

This PR is for the dev branch rather than for the release branch.
This PR is compliant with the other contributing guidelines as well (if not, please describe why).
I have thoroughly tested my contribution.
The code changes are reflected in the documentation at docs/*.

for the prepare release note workflow to work it has to run on specific os versions


          set windows and ubuntu versions of build VM to fixed version instead …

e71b07d

…of latest

HHHartmann changed the base branch from release to dev

February 24, 2024 07:25

Member

marcelstoer commented Feb 24, 2024

I'm not sure if this fix is correct or if not fixing it would cause any issues. However, fix at least brings this on par with what we have in the build script at https://github.com/nodemcu/nodemcu-firmware/blob/dev/.github/workflows/build.yml.

marcelstoer approved these changes

View reviewed changes

marcelstoer merged commit 36cbf9f into nodemcu:dev

18 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet