-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some bugs and problems in gossip #3527
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d closed sockets to send
Please review and/or merge |
@alexandruantochi would you care to have a look? |
Anyone mind if I merge this? |
I'll merge it. It's been up for review for nearly two weeks, the original author didn't even reply...you did what you could. |
Thx |
marcelstoer
pushed a commit
that referenced
this pull request
Feb 25, 2024
* Allow configuration of debugOutput to be performed * don't send to own IP or update own data * Use same socket to send and receive. Avoid problems in many opened and closed sockets to send * Add callback for REMOVEed hosts * Send broascast messages if seedList is empty * Adapt yeelink to new luacheck rules * Fix building of luac.cross for win to win2019 and VS 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues in gossip.
dev
branch rather than for therelease
branch.docs/*
.During working with gossip I found some bugs and weaknesses.