Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs and problems in gossip #3527

Merged
merged 7 commits into from
Jul 10, 2022
Merged

Conversation

HHHartmann
Copy link
Member

Fixes issues in gossip.

  • This PR is for the dev branch rather than for the release branch.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

During working with gossip I found some bugs and weaknesses.

@HHHartmann
Copy link
Member Author

Please review and/or merge

@HHHartmann
Copy link
Member Author

@alexandruantochi would you care to have a look?

@HHHartmann
Copy link
Member Author

Anyone mind if I merge this?

@marcelstoer
Copy link
Member

I'll merge it. It's been up for review for nearly two weeks, the original author didn't even reply...you did what you could.

@marcelstoer marcelstoer merged commit 193fe35 into nodemcu:dev Jul 10, 2022
@HHHartmann
Copy link
Member Author

Thx

marcelstoer pushed a commit that referenced this pull request Feb 25, 2024
* Allow configuration of debugOutput to be performed

* don't send to own IP or update own data

* Use same socket to send and receive. Avoid problems in many opened and closed sockets to send

* Add callback for REMOVEed hosts

* Send broascast messages if seedList is empty

* Adapt yeelink to new luacheck rules

* Fix building of luac.cross for win to win2019 and VS 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants