Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for open networks to enduser_setup #3392

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Add support for open networks to enduser_setup #3392

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e19102d
solved open network issue3374
blobule Jan 31, 2021
616a0ad
Merge branch 'dev' of https://github.com/nodemcu/nodemcu-firmware int…
blobule Feb 2, 2021
d7fa22b
added adequate messages amd update docs
blobule Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/modules/enduser_setup.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,9 +832,14 @@ static int enduser_setup_http_handle_credentials(char *data, unsigned short data
state->success = 0;
state->lastStationStatus = 0;


char *name_str = strstr(data, "wifi_ssid=");
char *pwd_str = strstr(data, "wifi_password=");
if (name_str == NULL || pwd_str == NULL)

// in case we dont get a passwd (for open networks)
if (pwd_str == NULL) { pwd_str="wifi_password="; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be an ENDUSER_SETUP_DEBUG note about this.
Maybe

ENDUSER_SETUP_DEBUG("Password string not found. Setting to empty");


if (name_str == NULL)
{
ENDUSER_SETUP_DEBUG("Password or SSID string not found");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adapt the Message. "SSID string not found"

return 1;
Expand Down