Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc update for bme280.lua #3384

Merged
merged 1 commit into from
Jan 24, 2021
Merged

Doc update for bme280.lua #3384

merged 1 commit into from
Jan 24, 2021

Conversation

Fivefold
Copy link
Contributor

Fixes #3383.

  • This PR is for the dev branch rather than for the release branch.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.
  1. Changed the note about bme280_math dependency into a blue note box, like in the bh1750 documentation
  2. Added a pagragraph on differentiating between BMP280 and BME280 sensors. It put it in an orange caution box for now, might be too visible for what's a rare problem.
  3. Small fixes in bme280.setup() description

@Fivefold
Doc update for bme280.lua
df38bd5 
1. Changed the note about bme280_math dependency into a blue note box, like in the [bh1750 documentation](https://nodemcu.readthedocs.io/en/release/lua-modules/bh1750/)
2. Added a pagragraph on differentiating between BMP280 and BME280 sensors. It put it in an orange caution box for now, might be too visible for a rare problem.
3. Small fixes in bme280.setup() description
@marcelstoer marcelstoer merged commit 2f452b2 into nodemcu:dev Jan 24, 2021
@marcelstoer
Copy link
Member

Thanks for the contribution!

@Fivefold Fivefold deleted the patch-1 branch January 24, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fivefold @marcelstoer