Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFC: Backport luaL_testudata to Lua 5.1 #3352

Merged
merged 1 commit into from
Dec 24, 2020
Merged

NFC: Backport luaL_testudata to Lua 5.1 #3352

merged 1 commit into from
Dec 24, 2020

Conversation

nwf
Copy link
Member

@nwf nwf commented Dec 20, 2020

And move luaL_checkudata to it, as in 5.3.

@nwf nwf mentioned this pull request Dec 20, 2020
Merged
4 tasks
@HHHartmann
Copy link
Member

Unfortunately typeerror also does not seem to be part of Lua 5.1

@nwf
NFC: Backport luaL_testudata to Lua 5.1
079ecc0 
And move luaL_checkudata to it, as in 5.3.
@nwf
Copy link
Member Author

nwf commented Dec 23, 2020

OK. Having stopped to actually read C, it looks like this is now CI green. Opinions?

@nwf
Copy link
Member Author

nwf commented Dec 24, 2020

Any objections to landing this? It should be fairly devoid of consequence...

@HHHartmann
Copy link
Member

LGTM

@HHHartmann HHHartmann merged commit b1d318d into nodemcu:dev Dec 24, 2020
@HHHartmann HHHartmann added this to the Next release milestone Dec 24, 2020
@nwf nwf deleted the lua51-testudata branch December 30, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
January 2021
Development

Successfully merging this pull request may close these issues.
2 participants
@nwf @HHHartmann