Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding '+' flag to string.format #3270

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Adding '+' flag to string.format #3270

merged 1 commit into from
Sep 9, 2020

Conversation

vsky279
Copy link
Contributor

@vsky279 vsky279 commented Sep 4, 2020

Fixes #3265.

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

It seems that adding the "+" formatting flag is not that complex.
I've done several tests but further independent testing is needed before it's merged.

@vsky279 vsky279 mentioned this pull request Sep 6, 2020
Closed
@TerryE TerryE self-requested a review September 7, 2020 10:38
@nwf nwf merged commit 64bbf00 into nodemcu:dev Sep 9, 2020
@marcelstoer marcelstoer added this to the Next release milestone Sep 9, 2020
@vsky279 vsky279 deleted the c_stringformat branch September 9, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TerryE TerryE TerryE approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
September 2020
Development

Successfully merging this pull request may close these issues.
4 participants
@vsky279 @TerryE @nwf @marcelstoer