-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for using doubles in the LUA53 build. #3225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nitpicks but in general I think this is a good idea
See comments on #3224. The Lua VM evaluates integer expressions using the default ( |
This version changes the option for a build to be double & 64-bit ints. In retrospect, I should have done this first time around. |
@HHHartmann I think that I have addressed all your issues. |
Sounds good to me.
…On Sun, Oct 25, 2020, 07:53 Marcel Stör ***@***.***> wrote:
@nwf <https://github.com/nwf> @pjsg <https://github.com/pjsg> as
discussed, ok for you if we land this immediately after the next master
drop (~1 week from now)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3225 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALQLTOE6OHFQHMLBSKEWMDSMQGTZANCNFSM4PALZARQ>
.
|
Fixes #3224.
dev
branch rather than formaster
.docs/*
.This brings back support for using doubles as the floating point format in the LUA53 build. This makes it much more compatible with the old LUA51 firmware.