DS18B20 Lua module - removing integer version related code #3150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure that I'm happy with this -- the integer builds are not going away yet. It might make sense to have two versions -- one for float builds and one for integer builds. |
|
Ok. I will add integer version of the module. I just don't like the garbage in the standard module version. |
vsky279
force-pushed
the
ds18b20-integer_out
branch
4 times, most recently
from
164b236 to
292b7e6
Compare
vsky279
force-pushed
the
ds18b20-integer_out
branch
2 times, most recently
from
0cce206 to
6c4e1bf
Compare
DS18B20 integer version Fix 2
vsky279
force-pushed
the
ds18b20-integer_out
branch
from
6c4e1bf to
06fce6b
Compare
|
I think we should decide whether to merge this or close the PR. Philip @pjsg? |
|
I vote to merge this one..... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - no reported issue.
devbranch rather than formaster.docs/*.This PR removes code supporting integer version of the firmware. As float version is now standard I think there is no reason to have integer version support in standard volume.