Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Kconfig #3138

Closed
wants to merge 2 commits into from
Closed

WIP: Kconfig #3138

wants to merge 2 commits into from

Conversation

nwf
Copy link
Member

@nwf nwf commented May 31, 2020

WIP on #3130

  • Define Kconfig files for user_modules.h
  • Define Kconfig files for most of user_config.h
  • Deal with the rest of user_config.h
  • Wire up .config generation
  • Replace use of CPP symbols with Kconfig symbols
  • user_mbedtls.h ?
  • user_modules.h -> .config script?
  • cloud builder

I will eagerly accept help on any of this. :)

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

@nwf nwf requested a review from jmattsson May 31, 2020 15:06
@@ -0,0 +1,289 @@
menu "Global Configuration Parameters"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I please suggest that this goes into the components/platform/Kconfig to match the esp32 branch? And we probably include the word "NodeMCU" in the menu name to make it easier to spot among the IDF things (especially on the esp32 IDF these days).

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@stale stale bot closed this Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants