Kconfig: rename LUA_MODULE_* to NODEMCU_CMODULE_* #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please see my discussion on #3130. This change makes no sense to me as these are Lua runtime modules, albeit written in C. If we really want to emphasise the "C-ness" of these then |
nwf
changed the title
nwf
added a commit
to nwf/nodemcu-custom-build
that referenced
this pull request
May 31, 2020
Synchronize with nodemcu/nodemcu-firmware#3135
marcelstoer
reviewed
May 31, 2020
Using the NODEMCU_ namespace prefix makes it obvious that these are not
part of Lua proper (contrast, e.g., LUA_BUILTIN_STRING). Using
"CMODULE" gives us room to differentiate between modules whose
implementation is in C and whose implemenation is in Lua ("LMODULE").
The ESP8266 branch can adopt the same convention when it moves to
Kconfig; see nodemcu#3130
|
I think it's ready, but it'd be good for someone with an ESP32 environment to look over my shoulder. |
marcelstoer
pushed a commit
to marcelstoer/nodemcu-custom-build
that referenced
this pull request
Aug 23, 2020
marcelstoer
pushed a commit
to marcelstoer/nodemcu-custom-build
that referenced
this pull request
Sep 15, 2020
marcelstoer
reviewed
Sep 17, 2020
| @@ -6,9 +6,9 @@ | |||
| #define NODE_VERSION_REVISION 0U | |||
| #define NODE_VERSION_INTERNAL 0U | |||
|
|
|||
| #define NODE_VERSION "NodeMCU ESP32" | |||
| #define NODE_VERSION "NodeMCU ESP32" " built with Docker provided by frightanic.com\n\tbranch: dev-esp32\n\tcommit: f4887bf134235c05e6c9b2efad370e6d5018f91a\n\tSSL: true\n\tmodules: -\n" | |||
There was a problem hiding this comment.
Arghh, missed this one...shouldn't have ended up in this change set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we begin to contemplate baking into firmware modules entirely written
in Lua or which are split between both Lua and C, the name LUA_MODULE_*
more obviously refers to the in-Lua bits, so rename the C ones out of
the way.
dev-esp32branch rather than formaster.docs/*.I have not yet convinced my machine to build for the esp32, but I think this is probably about right. Still, someone checking for me would be welcome.
This is part of #3130, indirectly, at least in keeping with the idea of harmonizing the two branches.