Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML for Apple devices to mitigate POST fragmentation #3069

Merged
merged 3 commits into from
Apr 25, 2020
Merged

HTML for Apple devices to mitigate POST fragmentation #3069

merged 3 commits into from
Apr 25, 2020

Conversation

HHHartmann
Copy link
Member

@HHHartmann HHHartmann commented Apr 13, 2020 •
edited
Loading

Fixes #2931.

Make sure all boxes are checked (add x inside the brackets) when you submit your contribution, remove this sentence before doing so.

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

This is an alternative html using a GET request to store credentials instead of a POST.
This is to mitigate the fragmentation of the POST shown on apple devices which can't be handled by enduser_setup currently.

Just copy the file enduser_setup_apple.html to the ESP and rename it to enduser_setup.html
It will then be used instead of the builtin html page.

Note! this html file is copied from prior working version and altered a bit.

Documentation is still missing. Just to try for interested users.

@HHHartmann HHHartmann mentioned this pull request Apr 13, 2020
Closed
@HHHartmann HHHartmann changed the title WIP! html for apple to mitigate handling POST failure html for apple to mitigate handling POST failure Apr 17, 2020
@HHHartmann HHHartmann requested a review from marcelstoer April 18, 2020 07:56
@HHHartmann HHHartmann added this to the Next release milestone Apr 18, 2020
@marcelstoer marcelstoer changed the title html for apple to mitigate handling POST failure WIP DNMY: HTML for Apple devices to mitigate POST fragmentation Apr 18, 2020
@nwf nwf mentioned this pull request Apr 25, 2020
Closed
@marcelstoer marcelstoer changed the title WIP DNMY: HTML for Apple devices to mitigate POST fragmentation HTML for Apple devices to mitigate POST fragmentation Apr 25, 2020
@marcelstoer marcelstoer merged commit 3c3bec9 into nodemcu:dev Apr 25, 2020
@HHHartmann HHHartmann deleted the enduser_setup_apple branch May 1, 2020 15:30
marcelstoer pushed a commit that referenced this pull request Jun 9, 2020
@HHHartmann @marcelstoer
HTML for Apple devices to mitigate POST fragmentation (#3069)
c50b478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelstoer marcelstoer marcelstoer approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
June 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@HHHartmann @marcelstoer