remove luacheck run for Travs and minor tweaks following #2838 #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
HHHartmann
reviewed
Jul 25, 2019
| - cd "$TRAVIS_BUILD_DIR" | ||
| - echo "checking:" | ||
| - find lua_modules lua_examples -iname "*.lua" -print0 | xargs -0 echo | ||
| - find lua_modules lua_examples -iname "*.lua" -print0 | xargs -0 $LUACC -p |
There was a problem hiding this comment.
Test compiling the lua sources can please stay in and the luacheck line might only get commented as we tend to want it back at some pint in time.
There was a problem hiding this comment.
@HHHartmann, Gregor if you feel strongly about this just do the PR and merge it. 😄
|
Will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch rather than formaster.Removes luacheck run from .Travis build as default and also picks up a couple of minor tweaks raised by @galjonsfigur in #2838 (comment)