-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1st Tranch of SDK 3.0 follow up changes #2732
Conversation
The issue with the Makefile is that the |
OK, the penny has dropped re the make failure. I dropped the use of |
…if OS not defined
Damn, |
Maybe it makes sense to export the OS variable in travis. yml then. |
@HHHartmann Gregor, to be honest it doesn't really matter which way. I find debugging the predicate logic in Makefiles a bit of a PITA, but the real lightbulb moment was just that there is something subtly different about the Travis make environment, and that I needed to do a couple of commit / pushes just to work out exactly what. They'll get rolled up in the "squash and merge" anyway. I'll add the node API calls today and merge this into dev. |
I have now added the get / set partition table calls to the node library, and documented these in |
Fixes #2689
dev
branch rather than formaster
.thoroughlytested my contribution.docs/*
.This is a fairly large change, with a summary of the details below
app/platform/platform.c
. Add support for R/W of Reboot Config Records (RCRs) to store configuration changes that persist across reboots using flash NAND writing rules. See inline comments for documentation. Flash erase is only carried out when GC of the RCR is required.📙 Note: IMO, it would be well worthwhile using this API to store the TLS certificates.
app/platform/platform.h
. Header changes to support the above.app/user/user_main.c
. This declares a static initial partition table RCR. A fairly major rework of theuser_pre_init()
code; this reads the current PT RTR and if this is the compiled one does calculation to work out the actual PT in RAM for the SDK to use. It then writes this updated RCR back for use on subsequent boots, so this calculation is one-time only.Note that this is designed to interoperate with the
tools/nodemcu-partition.py
utility and thenode
API so that you can configure the LFS or SPIFFS partitions at compile time, over UART configuration, or at runtime.app/include/user_config.h
. Following review feedback, I have changed this so that you can still set the compile-time default partition sizes for LFS and SPIFFS here.tools/nodemcu-partition.py
. Supports simple configuration of the LFS or SPIFFS partitions and downloading of LFS and SPIFFS images via this script. For example the following commands download a firmware image, then sets the LFS partition to 128KB and loads it with an LFS image over the UART:app/modules/node.c
. Addition ofnode.readrcr()
andnode.writercr()
if the macro DEVELOPMENT_TOOLS is defined.🔴 Not documented since these functions are only available for development.
🔴 the extra functions to query and to update the PT need to be added.
app/libc/c_string.h
. Minor change to addc_memmove
mapping toets_memmove
.ld/nodemcu.ld
. Force KEEP() on the RCR page.