Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unaligned load/store exception in luaR_findentry #2702

Merged
merged 1 commit into from
Mar 24, 2019
Merged

Fix unaligned load/store exception in luaR_findentry #2702

merged 1 commit into from
Mar 24, 2019

Conversation

TerryE
Copy link
Collaborator

@TerryE TerryE commented Mar 24, 2019

Fixes #2701

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • No documentation changes required at docs/en/*.

Removes the possible unaligned fetch in luaR_findentry()

@marcelstoer, IMO we should add this to the current dev->master cut.

@nwf
Copy link
Member

nwf commented Mar 24, 2019

LGTM. I agree with this landing in the current dev->master cut.

@pjsg
Copy link
Member

pjsg commented Mar 24, 2019

Looks good to me....

@TerryE TerryE merged commit 3f5ae99 into nodemcu:dev Mar 24, 2019
@marcelstoer marcelstoer added this to the Next release milestone Mar 25, 2019
@TerryE TerryE deleted the dev-luaR_findentry-fix branch March 25, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
Winter 2019
Development

Successfully merging this pull request may close these issues.
4 participants
@TerryE @nwf @pjsg @marcelstoer