Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for lack of nil return in file.read() when EOF is reached #2383

Merged
merged 1 commit into from
May 27, 2018
Merged

Fix for lack of nil return in file.read() when EOF is reached #2383

merged 1 commit into from
May 27, 2018

Conversation

dnc40085
Copy link
Contributor

Fixes #2376.

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.

This PR adds the missing nil return when a file is stepped through with print(file.read()) and the end of file is reached.

@TerryE
Copy link
Collaborator

TerryE commented May 27, 2018

It's a pity that you didn't go through the rest of the modules and fix the other instances of this but I suppose a tiny step forward is still a step forward.

@TerryE TerryE merged commit 994e8fa into nodemcu:dev May 27, 2018
@marcelstoer marcelstoer added this to the 2.2-follow-up milestone May 27, 2018
@marcelstoer
Copy link
Member

a step forward is still a step forward

👍-> thanks @dnc40085

@dnc40085 dnc40085 deleted the dev_file.read()_retval_fix branch May 28, 2018 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
2.2-follow-up
Development

Successfully merging this pull request may close these issues.
3 participants
@dnc40085 @TerryE @marcelstoer