Put each ICACHE_RAM_ATTR function in its own section. #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TerryE
reviewed
Mar 31, 2018
app/include/user_config.h
Outdated
| @@ -52,7 +52,9 @@ extern void luaL_assertfail(const char *file, int line, const char *message); | |||
|
|
|||
| #define ICACHE_STORE_TYPEDEF_ATTR __attribute__((aligned(4),packed)) | |||
| #define ICACHE_STORE_ATTR __attribute__((aligned(4))) | |||
| #define ICACHE_RAM_ATTR __attribute__((section(".iram0.text"))) | |||
| #define STRINGIZE(x) STRINGIZE2(x) | |||
There was a problem hiding this comment.
Defines in user_confgi.h in practice end up getting included in most modules and platform files, so should these be prefixed to remove the risk of a collision with another use of STRINGIZE, e.g.
STRINGIZE->ICACHE_STRINGIZESTRINGIZE2->ICACHE_STRINGIZE2
Other than that, 👍
|
It turns out that the hw_timer is included by default as it is needed by the gpio.serout functionality that is part of the default build.... I fixed the macro names... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2304.
devbranch rather than formaster.This implements putting each ICACHE_RAM_ATTR function in its own section. This allows the linker to throw away more functions and hence use less ram.
I checked the map and it looks good. The image boots and seems to work.