Another dsleep fix (or rather a not-deep-sleep case) #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With @mkresse having tested this I think we're good to go. |
crasu
pushed a commit
to crasu/nodemcu-firmware
that referenced
this pull request
Jan 11, 2018
* Make the rtc variables not be cleared by the .bss initialization * Move the save to the right place * Make sure that we reset the rtctime to 0 if we didn't sleep properly. * Setting the seconds to zero doesn't update the dsleep calibration
dnc40085
pushed a commit
to dnc40085/nodemcu-firmware
that referenced
this pull request
Mar 3, 2018
* Make the rtc variables not be cleared by the .bss initialization * Move the save to the right place * Make sure that we reset the rtctime to 0 if we didn't sleep properly. * Setting the seconds to zero doesn't update the dsleep calibration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2154.
Make sure all boxes are checked (add x inside the brackets) when you submit your contribution, remove this sentence before doing so.
devbranch rather than formaster.We now always reset the configuration if the rtc contains data that is not a valid deep sleep setting. If it is valid, that seems to work as well.